From 20bcc75798af1bde6752afb6052a335fd8bf8a87 Mon Sep 17 00:00:00 2001 From: Conrad Hoffmann Date: Fri, 24 Oct 2025 16:20:39 +0200 Subject: [PATCH] webhooks: improve usage of slices.Contains This was (rightfully) suggested by modernize [1], but the result can be easily improved even further. [1] https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize --- webhooks/legacy.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/webhooks/legacy.go b/webhooks/legacy.go index d7b54f49f7ce0e656e00b8e3743d92164d5a936a..3b096fd47d073cf3e6edd6a78efb2b9ffe01b53f 100644 --- a/webhooks/legacy.go +++ b/webhooks/legacy.go @@ -134,11 +134,7 @@ func fetchSubscriptions(ctx context.Context, q sq.SelectBuilder, // double check here to get the final list. sub.Events = strings.Split(events, ",") - var valid bool - if slices.Contains(sub.Events, event) { - valid = true - } - + valid := slices.Contains(sub.Events, event) if valid { subs = append(subs, &sub) }