~bigbes/core-go: errors: fix comparison in errors.Is()

7f734c73acb2c577b047bcd0d9f0e5a453da91ab — Conrad Hoffmann 3 months ago 67e6552

errors: fix comparison in errors.Is()

The code operates compares two values of compile-time type `any`. The
common use case however is to compare an error from `client.Do()` to one
of the reference errors, for example:

    if errors.Is(err, errors.ErrNotFound) {
        ...
    }

However, due to how the reference errors are constructed, their error
codes are of runtime-type `errors.ErrorCode`, whereas anything that got
parsed from a JSON response by `gqlerrors` will always be of
runtime-type `string`. Hence, Go will consider the two instances not
equal at runtime. Here [1] is little playground example demonstrating
the behavior.

To fix it, simply cast the special error type to back to string before
putting it in the map.

[1]: https://go.dev/play/p/pzxuhnnIeIK

patch browse .tar.gz .zip

1 files changed, 1 insertions(+), 1 deletions(-)

M errors/errors.go

M errors/errors.go => errors/errors.go +1 -1

@@ 13,7 13,7 @@ type ErrorCode string
 func New(code ErrorCode, message string) *gqlerror.Error {
 	return &gqlerror.Error{
 		Message:    message,
-		Extensions: map[string]any{"code": code},
+		Extensions: map[string]any{"code": string(code)},
 	}
 }