From 3199ab3b028b114b770415242292737a766bda3a Mon Sep 17 00:00:00 2001 From: Eugene Blikh Date: Thu, 23 Jul 2026 07:26:33 +0300 Subject: [PATCH] =?UTF-8?q?docs(patches):=20correct=20core-go-checksum=20w?= =?UTF-8?q?iring=20=E2=80=94=20fork=20dependency=20+=20build-time=20git=20?= =?UTF-8?q?apply,=20no=20replace=20in=20a=20compare=20service?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- patches/README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/patches/README.md b/patches/README.md index d4d364eec863040abb31f427c9ccfd13010f33dc..31393e06c9fb911f20d303b3c4a128e79aecb5cd 100644 --- a/patches/README.md +++ b/patches/README.md @@ -21,7 +21,10 @@ This hits two upload paths in production: **Fix.** Set both `RequestChecksumCalculation` and `ResponseChecksumValidation` to `WhenRequired`, so the SDK only checksums when the protocol mandates it. This restores pre-SDK-v1.30 behavior and is the workaround Amazon documents for non-AWS S3 backends (Garage/Ceph/Minio) where strict checksum negotiation is also unreliable. -**Status.** Applied in phoebe-lab production; **not upstreamed yet**. Also lives as commit `c2c2f3848fa9a88d96952ff08f886483f8b9d1f7` on `master` of the fork `git.srht.bigb.es/~bigbes/core-go` (branched from upstream `71b2787`), pinned via a `replace` directive in the `go.bigb.es/sourcehut-compare` service. +**Status.** Applied in phoebe-lab production; **not upstreamed yet**. It reaches production two ways, both from the copy in `~/data/home/phoebe-lab/srht/patches/`: + +- **Baked into the fork** `sourcecraft.dev/bigbes/sr-ht-core` (upstream core-go + this patch), consumed by the three custom Go services (`sr-ht-compare`, `sr-ht-dolt`, `sr-ht-spec`) as a normal pinned `go.mod` dependency — *not* via a `replace` directive. +- **`git apply`d at image-build time** by the two stack services built from source against upstream core-go: `Dockerfile.pages` and `Dockerfile.builds-worker` each `git clone` core-go (at `SRHT_PAGES_COREGO_REV` / `SRHT_BUILDS_COREGO_REV`), `git apply` this patch, then `go mod edit -replace` onto the patched tree. The `srht-build-1` worker binary reapplies it the same way via `update-worker`. The apk-packaged `builds.sr.ht` api/web is stock (unpatched) — it never uploads to S3, so it doesn't need it. **Verify it still applies cleanly:**