~bigbes/core-go

ref: 43a2be15d5b7c7bf3746cd5d7088143efae9b6a1 core-go/database/middleware.go -rw-r--r-- 1.3 KiB
43a2be15 — Simon Ser 3 years ago
database/middleware: don't use sql.Conn in WithTx

We can just use sql.DB instead of sql.Conn here. Simplifies the
code and reduces the risk of getting "bad connection" errors.
209e1a86 — Simon Ser 3 years ago
database/middleware: do not recover/panic in defer

defer always runs after a panic. There is no need to recover and
re-panic, we can just unconditionally tx.Rollback() (it will
silently error out if the transaction has already been committed or
rolled back).

This fixes the stack trace of the panic being incorrect. It points
to this function instead of the real culprit.
7ccaeb92 — Drew DeVault 5 years ago
database: panic on errors from Commit/Rollback

The previous change would eat the error from fn(tx); in truth we should
ensure that it is returned to the caller. This panics instead if an
error occurs during Commit or Rollback. I'm not sure of what scenarios
would cause this to occur, but they all probably deserve further
investigation - a panic will raise it to our attention.
a7d80e21 — Drew DeVault 5 years ago
database: handle Commit/Rollback errors
33562018 — Drew DeVault 5 years ago
database.WithTx: rollback if func returns error

Previously, this only rolled back if the called function panicked. This
updates it to also roll back if the called function returns an error.
14f4b921 — Drew DeVault 5 years ago
Expand context for work queues
bfc744fc — Drew DeVault 5 years ago
Add basic auth tests
1d2a30cb — Drew DeVault 5 years ago
Import GQL server interfaces from gql.sr.ht