~bigbes/lethe

ref: b100feee542aaacd159d90f8c35b2c68a26e8893 lethe/internal/platform/database/database_test.go -rw-r--r-- 12.6 KiB
b100feee — Eugene Blikh web: home route with real session list, filters, keyboard cursor a month ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
package database

import (
	"context"
	"errors"
	"testing"
	"time"

	"github.com/jmoiron/sqlx"
	_ "modernc.org/sqlite"

	"sourcecraft.dev/bigbes/lethe/internal/config"
)

// openTestDB opens a fresh :memory: SQLite database with the same pragmas the
// real Database service applies, then runs Migrate. Each call returns a
// distinct in-memory database; we use the modernc.org/sqlite "?_pragma="
// query parameters to guarantee FK enforcement and WAL/busy timeout settings
// match production.
func openTestDB(t *testing.T) *sqlx.DB {
	t.Helper()
	dsn := buildDSN(":memory:", 5*time.Second)
	db, err := sqlx.Connect("sqlite", dsn)
	if err != nil {
		t.Fatalf("connect: %v", err)
	}
	t.Cleanup(func() { _ = db.Close() })
	if err := Migrate(db); err != nil {
		t.Fatalf("migrate: %v", err)
	}
	return db
}

func insertSession(t *testing.T, db *sqlx.DB, owner, tool, host, sessionID string) {
	t.Helper()
	_, err := db.Exec(`
		INSERT INTO sessions
			(owner, tool, host, session_id, started_at, ended_at, working_dir, source_file, metadata)
		VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)
	`, owner, tool, host, sessionID, 1700000000, 1700000100, nil, "/tmp/x.jsonl", nil)
	if err != nil {
		t.Fatalf("insert session: %v", err)
	}
}

func insertTurn(t *testing.T, db *sqlx.DB, owner, tool, host, sessionID, turnID, content string, toolCalls *string) {
	t.Helper()
	_, err := db.Exec(`
		INSERT INTO turns
			(owner, tool, host, session_id, turn_id, seq, role, timestamp, content, tool_calls)
		VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
	`, owner, tool, host, sessionID, turnID, 1, "user", 1700000050, content, toolCalls)
	if err != nil {
		t.Fatalf("insert turn: %v", err)
	}
}

func TestMigrateIsIdempotent(t *testing.T) {
	dsn := buildDSN(":memory:", 5*time.Second)
	db, err := sqlx.Connect("sqlite", dsn)
	if err != nil {
		t.Fatalf("connect: %v", err)
	}
	t.Cleanup(func() { _ = db.Close() })

	if err := Migrate(db); err != nil {
		t.Fatalf("first migrate: %v", err)
	}
	// Second invocation must succeed (golang-migrate returns ErrNoChange,
	// which Migrate translates into nil).
	if err := Migrate(db); err != nil {
		t.Fatalf("second migrate: %v", err)
	}
}

func TestTurnInsertPopulatesTurnsFTSWithOwner(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	insertTurn(t, db, "alice", "cc", "phoebe", "s1", "t1", "hello world from alice", nil)

	var n int
	if err := db.Get(&n, `SELECT COUNT(*) FROM turns_fts WHERE owner = 'alice' AND turns_fts MATCH 'hello'`); err != nil {
		t.Fatalf("query fts: %v", err)
	}
	if n != 1 {
		t.Fatalf("expected 1 fts row for owner=alice matching 'hello', got %d", n)
	}
}

func TestTurnUpdateUpdatesTurnsFTS(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	insertTurn(t, db, "alice", "cc", "phoebe", "s1", "t1", "original phrase", nil)

	if _, err := db.Exec(`
		UPDATE turns SET content = ? WHERE owner = ? AND tool = ? AND host = ? AND session_id = ? AND turn_id = ?
	`, "replaced phrase", "alice", "cc", "phoebe", "s1", "t1"); err != nil {
		t.Fatalf("update: %v", err)
	}

	var oldHits, newHits int
	if err := db.Get(&oldHits, `SELECT COUNT(*) FROM turns_fts WHERE turns_fts MATCH 'original'`); err != nil {
		t.Fatalf("query old: %v", err)
	}
	if err := db.Get(&newHits, `SELECT COUNT(*) FROM turns_fts WHERE turns_fts MATCH 'replaced'`); err != nil {
		t.Fatalf("query new: %v", err)
	}
	if oldHits != 0 {
		t.Fatalf("expected 0 hits for 'original' after update, got %d", oldHits)
	}
	if newHits != 1 {
		t.Fatalf("expected 1 hit for 'replaced' after update, got %d", newHits)
	}
}

func TestTurnDeleteRemovesFromTurnsFTS(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	insertTurn(t, db, "alice", "cc", "phoebe", "s1", "t1", "doomed content", nil)

	if _, err := db.Exec(`DELETE FROM turns WHERE turn_id = ?`, "t1"); err != nil {
		t.Fatalf("delete: %v", err)
	}

	var n int
	if err := db.Get(&n, `SELECT COUNT(*) FROM turns_fts`); err != nil {
		t.Fatalf("query fts: %v", err)
	}
	if n != 0 {
		t.Fatalf("expected empty turns_fts after delete, got %d rows", n)
	}
}

func TestToolOutputsFTSInsertUpdateDeleteWhenToolCallsPresent(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	tc := `{"name":"shell","args":"ls /tmp"}`
	insertTurn(t, db, "alice", "cc", "phoebe", "s1", "t1", "running tool", &tc)

	var hits int
	if err := db.Get(&hits, `SELECT COUNT(*) FROM tool_outputs_fts WHERE owner = 'alice' AND tool_outputs_fts MATCH 'shell'`); err != nil {
		t.Fatalf("query insert: %v", err)
	}
	if hits != 1 {
		t.Fatalf("expected 1 tool_outputs_fts row, got %d", hits)
	}

	tc2 := `{"name":"editor","args":"open"}`
	if _, err := db.Exec(`UPDATE turns SET tool_calls = ? WHERE turn_id = ?`, tc2, "t1"); err != nil {
		t.Fatalf("update tool_calls: %v", err)
	}
	if err := db.Get(&hits, `SELECT COUNT(*) FROM tool_outputs_fts WHERE tool_outputs_fts MATCH 'editor'`); err != nil {
		t.Fatalf("query update: %v", err)
	}
	if hits != 1 {
		t.Fatalf("expected 1 hit after update, got %d", hits)
	}
	if err := db.Get(&hits, `SELECT COUNT(*) FROM tool_outputs_fts WHERE tool_outputs_fts MATCH 'shell'`); err != nil {
		t.Fatalf("query update old: %v", err)
	}
	if hits != 0 {
		t.Fatalf("expected 0 hits for old tool_calls after update, got %d", hits)
	}

	if _, err := db.Exec(`DELETE FROM turns WHERE turn_id = ?`, "t1"); err != nil {
		t.Fatalf("delete: %v", err)
	}
	if err := db.Get(&hits, `SELECT COUNT(*) FROM tool_outputs_fts`); err != nil {
		t.Fatalf("query delete: %v", err)
	}
	if hits != 0 {
		t.Fatalf("expected empty tool_outputs_fts after delete, got %d", hits)
	}
}

func TestToolOutputsFTSSkipsNullToolCalls(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	insertTurn(t, db, "alice", "cc", "phoebe", "s1", "t1", "no tool call here", nil)

	var n int
	if err := db.Get(&n, `SELECT COUNT(*) FROM tool_outputs_fts`); err != nil {
		t.Fatalf("count: %v", err)
	}
	if n != 0 {
		t.Fatalf("expected tool_outputs_fts empty when tool_calls is NULL, got %d", n)
	}
}

func TestForeignKeyRejectsOrphanTurn(t *testing.T) {
	db := openTestDB(t)
	// No sessions row inserted.
	_, err := db.Exec(`
		INSERT INTO turns
			(owner, tool, host, session_id, turn_id, seq, role, timestamp, content)
		VALUES ('alice', 'cc', 'phoebe', 'ghost', 't1', 1, 'user', 1700000050, 'no parent')
	`)
	if err == nil {
		t.Fatalf("expected FK violation, got nil")
	}
}

func TestTwoOwnersSameSessionTriple(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	insertSession(t, db, "bob", "cc", "phoebe", "s1")

	var n int
	if err := db.Get(&n, `SELECT COUNT(*) FROM sessions WHERE tool = 'cc' AND host = 'phoebe' AND session_id = 's1'`); err != nil {
		t.Fatalf("count: %v", err)
	}
	if n != 2 {
		t.Fatalf("expected 2 sessions across owners, got %d", n)
	}
}

func TestFTSQueryFiltersByOwner(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")
	insertSession(t, db, "bob", "cc", "phoebe", "s2")
	insertTurn(t, db, "alice", "cc", "phoebe", "s1", "t1", "the quick brown fox", nil)
	insertTurn(t, db, "bob", "cc", "phoebe", "s2", "t1", "the quick brown fox", nil)

	var alice, bob int
	if err := db.Get(&alice, `SELECT COUNT(*) FROM turns_fts WHERE owner = 'alice' AND turns_fts MATCH 'quick'`); err != nil {
		t.Fatalf("alice: %v", err)
	}
	if err := db.Get(&bob, `SELECT COUNT(*) FROM turns_fts WHERE owner = 'bob' AND turns_fts MATCH 'quick'`); err != nil {
		t.Fatalf("bob: %v", err)
	}
	if alice != 1 || bob != 1 {
		t.Fatalf("expected 1 hit per owner, got alice=%d bob=%d", alice, bob)
	}

	// And cross-check overall row count is exactly 2.
	var total int
	if err := db.Get(&total, `SELECT COUNT(*) FROM turns_fts WHERE turns_fts MATCH 'quick'`); err != nil {
		t.Fatalf("total: %v", err)
	}
	if total != 2 {
		t.Fatalf("expected 2 total fts hits, got %d", total)
	}
}

func TestUpsertFiresUpdateTriggerAndKeepsFTSCoherent(t *testing.T) {
	// Phase 7's ingest path uses INSERT ... ON CONFLICT DO UPDATE, which
	// fires the UPDATE trigger (not INSERT) when the conflict branch is
	// taken. Pin that contract here so a future SQLite/FTS5 regression
	// trips a test instead of corrupting the index in production.
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")

	// First insert.
	if _, err := db.Exec(`
		INSERT INTO turns
			(owner, tool, host, session_id, turn_id, seq, role, timestamp, content, tool_calls)
		VALUES ('alice','cc','phoebe','s1','t1',1,'user',1700000050,'first version', '{"name":"first"}')
	`); err != nil {
		t.Fatalf("first insert: %v", err)
	}

	// Upsert with new content + new tool_calls. We exercise the same shape
	// the ingest service will use: ON CONFLICT on the full composite PK
	// with DO UPDATE SET on the mutating columns.
	if _, err := db.Exec(`
		INSERT INTO turns
			(owner, tool, host, session_id, turn_id, seq, role, timestamp, content, tool_calls)
		VALUES ('alice','cc','phoebe','s1','t1',1,'user',1700000060,'second version', '{"name":"second"}')
		ON CONFLICT (owner, tool, host, session_id, turn_id) DO UPDATE SET
			content    = excluded.content,
			tool_calls = excluded.tool_calls,
			timestamp  = excluded.timestamp
	`); err != nil {
		t.Fatalf("upsert: %v", err)
	}

	// turns_fts: only "second" should match; "first" should not.
	var n int
	if err := db.Get(&n, `SELECT COUNT(*) FROM turns_fts WHERE turns_fts MATCH 'first'`); err != nil {
		t.Fatalf("query first: %v", err)
	}
	if n != 0 {
		t.Fatalf("expected old 'first' content gone after upsert, got %d hits", n)
	}
	if err := db.Get(&n, `SELECT COUNT(*) FROM turns_fts WHERE turns_fts MATCH 'second'`); err != nil {
		t.Fatalf("query second: %v", err)
	}
	if n != 1 {
		t.Fatalf("expected 1 hit for new 'second' content after upsert, got %d", n)
	}

	// tool_outputs_fts: same expectation on the JSON column.
	if err := db.Get(&n, `SELECT COUNT(*) FROM tool_outputs_fts WHERE tool_outputs_fts MATCH 'first'`); err != nil {
		t.Fatalf("query tc first: %v", err)
	}
	if n != 0 {
		t.Fatalf("expected old tool_calls gone after upsert, got %d", n)
	}
	if err := db.Get(&n, `SELECT COUNT(*) FROM tool_outputs_fts WHERE tool_outputs_fts MATCH 'second'`); err != nil {
		t.Fatalf("query tc second: %v", err)
	}
	if n != 1 {
		t.Fatalf("expected 1 hit for new tool_calls after upsert, got %d", n)
	}
}

func TestDatabaseInitDestroyOnMemoryDSN(t *testing.T) {
	// End-to-end: the steward Init/Destroy contract drives the whole stack
	// (DSN build + connect + migrate + close).
	d := &Database{
		Cfg: config.DatabaseConfig{
			Path:        ":memory:",
			BusyTimeout: 5 * time.Second,
		},
	}
	ctx := context.Background()
	if err := d.Init(ctx); err != nil {
		t.Fatalf("Init: %v", err)
	}
	if d.DB == nil {
		t.Fatalf("expected DB populated after Init")
	}
	// Confirm migrations ran end-to-end through Init.
	var n int
	if err := d.DB.Get(&n, `SELECT COUNT(*) FROM sqlite_master WHERE type = 'table' AND name = 'sessions'`); err != nil {
		t.Fatalf("query schema: %v", err)
	}
	if n != 1 {
		t.Fatalf("expected sessions table to exist, got %d", n)
	}
	if err := d.Destroy(ctx); err != nil {
		t.Fatalf("Destroy: %v", err)
	}
	// Idempotent on second Destroy.
	if err := d.Destroy(ctx); err != nil {
		t.Fatalf("second Destroy must be a no-op, got %v", err)
	}
}

func TestInTxCommitAndRollback(t *testing.T) {
	db := openTestDB(t)
	insertSession(t, db, "alice", "cc", "phoebe", "s1")

	// Commit path: insert a turn inside InTx, expect it visible after.
	if err := InTx(context.Background(), db, func(tx *sqlx.Tx) error {
		_, err := tx.Exec(`
			INSERT INTO turns
				(owner, tool, host, session_id, turn_id, seq, role, timestamp, content)
			VALUES ('alice', 'cc', 'phoebe', 's1', 't1', 1, 'user', 1700000050, 'committed')
		`)
		return err
	}); err != nil {
		t.Fatalf("InTx commit: %v", err)
	}
	var n int
	if err := db.Get(&n, `SELECT COUNT(*) FROM turns WHERE turn_id = 't1'`); err != nil {
		t.Fatalf("count: %v", err)
	}
	if n != 1 {
		t.Fatalf("commit path: expected 1 turn, got %d", n)
	}

	// Rollback path: error inside fn rolls back; InTx returns the error.
	sentinel := errors.New("rollback me")
	err := InTx(context.Background(), db, func(tx *sqlx.Tx) error {
		if _, err := tx.Exec(`
			INSERT INTO turns
				(owner, tool, host, session_id, turn_id, seq, role, timestamp, content)
			VALUES ('alice', 'cc', 'phoebe', 's1', 't2', 2, 'user', 1700000060, 'rolled back')
		`); err != nil {
			return err
		}
		return sentinel
	})
	if !errors.Is(err, sentinel) {
		t.Fatalf("expected sentinel error from InTx, got %v", err)
	}
	if err := db.Get(&n, `SELECT COUNT(*) FROM turns WHERE turn_id = 't2'`); err != nil {
		t.Fatalf("count after rollback: %v", err)
	}
	if n != 0 {
		t.Fatalf("rollback path: expected 0 rows for t2, got %d", n)
	}
}