~bigbes/lethe

ref: f3118d95bdf88c114346b0b2b43fad44e564a484 lethe/internal/collector/ingest/runner_test.go -rw-r--r-- 12.6 KiB
f3118d95 — Eugene Blikh collector: preserve valid rows around ingest errors 24 days ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
package ingest

import (
	"context"
	"encoding/json"
	"io"
	"net/http"
	"net/http/httptest"
	"path/filepath"
	"strings"
	"sync"
	"testing"
	"time"

	"sourcecraft.dev/bigbes/lethe/internal/collector/config"
	"sourcecraft.dev/bigbes/lethe/internal/collector/parser"
	"sourcecraft.dev/bigbes/lethe/internal/shared/wire"
)

func TestRunOnce_AllAcceptedPersistsNewOffsetAndDoesNotEnqueueOutbox(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b")}, newOffset: 300},
	})
	sender := acceptingSender(t, []Result{{Accepted: 2}})

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce: %v", err)
	}

	assertOffset(t, ctx, store, "claude-code", file, 300)
	assertOutboxCount(t, ctx, store, 0)
}

func TestRunOnce_PartialAcceptWithErrorSkipsFailedEvent(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b"), turnEvent(300, "c")}, newOffset: 400},
	})
	sender := acceptingSender(t, []Result{{Accepted: 1, Errors: []LineError{{Line: 2, Err: "bad"}}}})

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce: %v", err)
	}

	assertOffset(t, ctx, store, "claude-code", file, 300)
	assertOutboxCount(t, ctx, store, 0)
}

func TestRunOnce_ZeroAcceptedWithErrorLineTwoPostsPrefixAndSkipsFailedEvent(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	events := []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b"), turnEvent(300, "c")}
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: events, newOffset: 400},
	})

	var posted [][]wire.TurnEvent
	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		body, _ := io.ReadAll(r.Body)
		var batch []wire.TurnEvent
		for _, line := range strings.Split(string(body), "\n") {
			if line == "" {
				continue
			}
			var ev wire.TurnEvent
			if err := json.Unmarshal([]byte(line), &ev); err != nil {
				t.Fatalf("unmarshal event: %v", err)
			}
			batch = append(batch, ev)
		}
		posted = append(posted, batch)
		w.Header().Set("Content-Type", "application/json")
		if len(posted) == 1 {
			_, _ = w.Write([]byte(resultJSON(Result{Accepted: 0, Errors: []LineError{{Line: 2, Err: "bad"}}})))
		} else {
			_, _ = w.Write([]byte(resultJSON(Result{Accepted: len(batch)})))
		}
	}))
	defer ts.Close()
	sender := NewSender(ts.URL, ts.Client())

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce first run: %v", err)
	}
	assertOffset(t, ctx, store, "claude-code", file, 300)

	if len(posted) != 2 {
		t.Fatalf("first run: expected 2 POSTs, got %d", len(posted))
	}
	if len(posted[0]) != 3 {
		t.Errorf("first run batch: expected 3 events, got %d", len(posted[0]))
	}
	if len(posted[1]) != 1 {
		t.Errorf("prefix batch: expected 1 event, got %d", len(posted[1]))
	}
	if posted[1][0].Content != "a" {
		t.Errorf("prefix batch: expected event 'a', got %q", posted[1][0].Content)
	}

	err = RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce second run: %v", err)
	}
	assertOffset(t, ctx, store, "claude-code", file, 400)

	if len(posted) != 3 {
		t.Fatalf("second run: expected 3 POSTs total, got %d", len(posted))
	}
	if len(posted[2]) != 1 {
		t.Errorf("second run batch: expected 1 event, got %d", len(posted[2]))
	}
	if posted[2][0].Content != "c" {
		t.Errorf("second run batch: expected event 'c', got %q", posted[2][0].Content)
	}
}

func TestRunOnce_MalformedErrorLineOutOfRangeReturnsError(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b")}, newOffset: 300},
	})
	sender := acceptingSender(t, []Result{{Accepted: 0, Errors: []LineError{{Line: 5, Err: "bad"}}}})

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err == nil {
		t.Fatal("expected RunOnce error for malformed error line")
	}

	assertOffset(t, ctx, store, "claude-code", file, 0)
}

func TestRunOnce_ZeroAcceptedWithErrorSkipsFirstEvent(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b")}, newOffset: 300},
	})
	sender := acceptingSender(t, []Result{{Accepted: 0, Errors: []LineError{{Line: 1, Err: "bad"}}}})

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce: %v", err)
	}

	assertOffset(t, ctx, store, "claude-code", file, 200)
	assertOutboxCount(t, ctx, store, 0)
}

func TestRunOnce_PartialAcceptSkipsBadRowAndRerunDoesNotRepostIt(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	events := []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b"), turnEvent(300, "c")}
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: events, newOffset: 400},
	})

	var posted [][]wire.TurnEvent
	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		body, _ := io.ReadAll(r.Body)
		var batch []wire.TurnEvent
		for _, line := range strings.Split(string(body), "\n") {
			if line == "" {
				continue
			}
			var ev wire.TurnEvent
			if err := json.Unmarshal([]byte(line), &ev); err != nil {
				t.Fatalf("unmarshal event: %v", err)
			}
			batch = append(batch, ev)
		}
		posted = append(posted, batch)
		w.Header().Set("Content-Type", "application/json")
		if len(posted) == 1 {
			_, _ = w.Write([]byte(resultJSON(Result{Accepted: 1, Errors: []LineError{{Line: 2, Err: "bad"}}})))
		} else {
			_, _ = w.Write([]byte(resultJSON(Result{Accepted: 1})))
		}
	}))
	defer ts.Close()
	sender := NewSender(ts.URL, ts.Client())

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce first run: %v", err)
	}
	assertOffset(t, ctx, store, "claude-code", file, 300)

	if len(posted) != 1 {
		t.Fatalf("first run: expected 1 POST, got %d", len(posted))
	}
	if len(posted[0]) != 3 {
		t.Errorf("first run: expected 3 events in batch, got %d", len(posted[0]))
	}

	err = RunOnce(ctx, testConfig(), source, p, store, sender)
	if err != nil {
		t.Fatalf("RunOnce second run: %v", err)
	}
	assertOffset(t, ctx, store, "claude-code", file, 400)

	if len(posted) != 2 {
		t.Fatalf("second run: expected 2 POSTs total, got %d", len(posted))
	}
	if len(posted[1]) != 1 {
		t.Errorf("second run: expected 1 event in batch, got %d", len(posted[1]))
	}
	if posted[1][0].Content != "c" {
		t.Errorf("second run: expected event 'c', got %q", posted[1][0].Content)
	}
}

func TestRunOnce_FullAcceptWithErrorsReturnsError(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b")}, newOffset: 300},
	})
	sender := acceptingSender(t, []Result{{Accepted: 2, Errors: []LineError{{Line: 2, Err: "bad"}}}})

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err == nil {
		t.Fatal("expected RunOnce error when server accepts all but reports errors")
	}

	assertOffset(t, ctx, store, "claude-code", file, 0)
}

func TestRunOnce_HardErrorEnqueuesUnsentBatchAndDoesNotAdvanceOffset(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	file := filepath.Join(source.Path, "one.jsonl")
	events := []wire.TurnEvent{turnEvent(100, "a"), turnEvent(200, "b")}
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: file}}, map[string]parseResult{
		file: {events: events, newOffset: 300},
	})
	sender := failingSender(t)

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err == nil {
		t.Fatal("expected RunOnce error on hard POST failure")
	}

	assertOffset(t, ctx, store, "claude-code", file, 0)
	rows, err := store.Oldest(ctx, 10)
	if err != nil {
		t.Fatalf("Oldest: %v", err)
	}
	if len(rows) != 1 {
		t.Fatalf("len(rows) = %d, want 1", len(rows))
	}
	wantPayload, err := EncodeNDJSON(events)
	if err != nil {
		t.Fatalf("EncodeNDJSON: %v", err)
	}
	if string(rows[0].Payload) != string(wantPayload) {
		t.Errorf("payload = %q, want %q", string(rows[0].Payload), string(wantPayload))
	}
}

func TestRunOnce_ContinuesToOtherFilesWhenOneFileFails(t *testing.T) {
	ctx := context.Background()
	store := openTestStore(t, ctx)
	source := testSource(t, "claude-code", 10, 4096)
	badFile := filepath.Join(source.Path, "bad.jsonl")
	goodFile := filepath.Join(source.Path, "good.jsonl")
	p := newFakeParser("claude-code", []parser.SourceFile{{Path: badFile}, {Path: goodFile}}, map[string]parseResult{
		badFile:  {err: errParseBoom},
		goodFile: {events: []wire.TurnEvent{turnEvent(100, "ok")}, newOffset: 200},
	})
	sender := acceptingSender(t, []Result{{Accepted: 1}})

	err := RunOnce(ctx, testConfig(), source, p, store, sender)
	if err == nil {
		t.Fatal("expected RunOnce to return collected parse error")
	}

	assertOffset(t, ctx, store, "claude-code", badFile, 0)
	assertOffset(t, ctx, store, "claude-code", goodFile, 200)
}

func TestRunDaemon_ExitsWhenContextCanceled(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	store := openTestStore(t, context.Background())
	source := testSource(t, "claude-code", 10, 4096)
	source.PollInterval = time.Hour
	p := newFakeParser("claude-code", nil, nil)
	sender := acceptingSender(t, nil)
	cfg := testConfig()
	cfg.Sources = []config.SourceConfig{source}

	done := make(chan error, 1)
	go func() {
		done <- RunDaemon(ctx, cfg, map[string]parser.Parser{"claude-code": p}, store, sender)
	}()

	cancel()
	select {
	case err := <-done:
		if err != nil {
			t.Fatalf("RunDaemon: %v", err)
		}
	case <-time.After(2 * time.Second):
		t.Fatal("RunDaemon did not exit after context cancellation")
	}
}

type parseResult struct {
	events    []wire.TurnEvent
	newOffset int64
	err       error
}

type fakeParser struct {
	tool    string
	files   []parser.SourceFile
	results map[string]parseResult
}

func newFakeParser(tool string, files []parser.SourceFile, results map[string]parseResult) *fakeParser {
	return &fakeParser{tool: tool, files: files, results: results}
}

func (p *fakeParser) Tool() string { return p.tool }

func (p *fakeParser) Discover(root string) ([]parser.SourceFile, error) { return p.files, nil }

func (p *fakeParser) Parse(path string, since int64) ([]wire.TurnEvent, int64, error) {
	res := p.results[path]
	if res.err != nil {
		return nil, since, res.err
	}
	var filtered []wire.TurnEvent
	for _, ev := range res.events {
		if ev.Seq >= since {
			filtered = append(filtered, ev)
		}
	}
	return filtered, res.newOffset, nil
}

type roundTripFunc func(*http.Request) (*http.Response, error)

func (f roundTripFunc) RoundTrip(r *http.Request) (*http.Response, error) { return f(r) }

func acceptingSender(t *testing.T, results []Result) *Sender {
	t.Helper()
	var mu sync.Mutex
	idx := 0
	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		_, _ = io.ReadAll(r.Body)
		mu.Lock()
		defer mu.Unlock()
		result := Result{Accepted: 0}
		if idx < len(results) {
			result = results[idx]
			idx++
		}
		w.Header().Set("Content-Type", "application/json")
		_, _ = w.Write([]byte(resultJSON(result)))
	}))
	t.Cleanup(ts.Close)
	return NewSender(ts.URL, ts.Client())
}

func failingSender(t *testing.T) *Sender {
	t.Helper()
	client := &http.Client{Transport: roundTripFunc(func(*http.Request) (*http.Response, error) {
		return nil, errPostBoom
	})}
	return NewSender("http://127.0.0.1", client)
}