~bigbes/sr-ht-compare

ref: 981e4f757186b9332105561c03e16c8afd6cf80c sr-ht-compare/gitx/gitx_test.go -rw-r--r-- 10.4 KiB
981e4f75 — bigbes fix(apk): keep -modcacherw when overriding GOFLAGS 13 days ago
                                                                                
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
package gitx

import (
	"context"
	"errors"
	"strings"
	"testing"

	"sourcecraft.dev/bigbes/sr-ht-compare/core"
)

func ctx() context.Context { return context.Background() }

func TestOpen(t *testing.T) {
	reposRoot := newFixtureRepo(t)

	t.Run("valid", func(t *testing.T) {
		repo, err := Open(reposRoot, fxOwner, fxName)
		if err != nil {
			t.Fatalf("Open: %v", err)
		}
		if !strings.HasSuffix(repo.Dir(), "~alice/demo") {
			t.Errorf("dir = %q", repo.Dir())
		}
	})

	// Every hostile input must fail with ErrNotFound and never escape reposRoot.
	traversal := []struct {
		name        string
		owner, repo string
	}{
		{"dotdot owner", "..", "demo"},
		{"tilde owner", "~evil", "demo"},
		{"slash in repo", "alice", "../../etc"},
		{"dotdot repo", "alice", ".."},
		{"absolute-ish repo", "alice", "/etc/passwd"},
		{"leading dash owner", "-x", "demo"},
		{"missing repo", "alice", "nonexistent"},
		{"missing owner", "bob", "demo"},
	}
	for _, tt := range traversal {
		t.Run(tt.name, func(t *testing.T) {
			_, err := Open(reposRoot, tt.owner, tt.repo)
			if err == nil {
				t.Fatalf("Open(%q,%q) succeeded, want error", tt.owner, tt.repo)
			}
			if !errors.Is(err, core.ErrNotFound) {
				t.Errorf("err = %v, want ErrNotFound", err)
			}
		})
	}
}

func TestRefs(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	branches, tags, err := repo.Refs(ctx())
	if err != nil {
		t.Fatalf("Refs: %v", err)
	}

	if len(branches) != 2 {
		t.Fatalf("branches = %v, want 2", branches)
	}
	if branches[0].Name != "main" {
		t.Errorf("branches[0] = %q, want HEAD branch main first", branches[0].Name)
	}
	if branches[1].Name != "feature/with-slash" {
		t.Errorf("branches[1] = %q, want feature/with-slash", branches[1].Name)
	}
	if branches[0].SHA != fxRev(t, reposRoot, "main") {
		t.Errorf("main SHA = %q, want %q", branches[0].SHA, fxRev(t, reposRoot, "main"))
	}

	if len(tags) != 2 {
		t.Fatalf("tags = %v, want 2", tags)
	}
	// Newest creator-date first: v1.0.0 was tagged after v0.9.0.
	if tags[0].Name != "v1.0.0" || tags[1].Name != "v0.9.0" {
		t.Errorf("tags order = [%q %q], want [v1.0.0 v0.9.0]", tags[0].Name, tags[1].Name)
	}

	def, err := repo.DefaultBranch(ctx())
	if err != nil {
		t.Fatalf("DefaultBranch: %v", err)
	}
	if def != "main" {
		t.Errorf("DefaultBranch = %q, want main", def)
	}
}

func TestResolveCommit(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	mainSHA := fxRev(t, reposRoot, "main")
	rootSHA := fxRev(t, reposRoot, "main^1~3")

	t.Run("branch", func(t *testing.T) {
		ci, err := repo.ResolveCommit(ctx(), "main")
		if err != nil {
			t.Fatalf("ResolveCommit(main): %v", err)
		}
		if ci.SHA != mainSHA {
			t.Errorf("SHA = %q, want %q", ci.SHA, mainSHA)
		}
		if len(ci.ParentSHAs) != 2 {
			t.Errorf("main is a merge, parents = %v", ci.ParentSHAs)
		}
		if ci.AuthorName != "Alice Example" {
			t.Errorf("author = %q", ci.AuthorName)
		}
	})

	t.Run("annotated tag peels to commit", func(t *testing.T) {
		ci, err := repo.ResolveCommit(ctx(), "v1.0.0")
		if err != nil {
			t.Fatalf("ResolveCommit(v1.0.0): %v", err)
		}
		if ci.SHA != mainSHA {
			t.Errorf("SHA = %q, want %q", ci.SHA, mainSHA)
		}
	})

	t.Run("full SHA", func(t *testing.T) {
		ci, err := repo.ResolveCommit(ctx(), rootSHA)
		if err != nil {
			t.Fatalf("ResolveCommit(root SHA): %v", err)
		}
		if ci.SHA != rootSHA {
			t.Errorf("SHA = %q, want %q", ci.SHA, rootSHA)
		}
		if len(ci.ParentSHAs) != 0 {
			t.Errorf("root parents = %v, want none", ci.ParentSHAs)
		}
	})

	t.Run("branch with slash", func(t *testing.T) {
		ci, err := repo.ResolveCommit(ctx(), "feature/with-slash")
		if err != nil {
			t.Fatalf("ResolveCommit(feature/with-slash): %v", err)
		}
		if ci.SHA != fxRev(t, reposRoot, "feature/with-slash") {
			t.Errorf("SHA = %q", ci.SHA)
		}
	})

	t.Run("nonexistent ref is ErrBadRef", func(t *testing.T) {
		_, err := repo.ResolveCommit(ctx(), "does-not-exist")
		if !errors.Is(err, core.ErrBadRef) {
			t.Errorf("err = %v, want ErrBadRef", err)
		}
	})

	t.Run("malformed ref is ErrBadRef", func(t *testing.T) {
		_, err := repo.ResolveCommit(ctx(), "@")
		if !errors.Is(err, core.ErrBadRef) {
			t.Errorf("err = %v, want ErrBadRef", err)
		}
	})
}

func TestLog(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	base := fxRev(t, reposRoot, "main^1~2") // c2
	head := fxRev(t, reposRoot, "main^1")   // binary commit

	commits, err := repo.Log(ctx(), base, head, 10)
	if err != nil {
		t.Fatalf("Log: %v", err)
	}
	if len(commits) != 2 {
		t.Fatalf("commits = %d, want 2 (rename, binary)", len(commits))
	}
	// Newest first.
	if !strings.HasPrefix(commits[0].Subject, "binary") {
		t.Errorf("commits[0] = %q, want binary", commits[0].Subject)
	}
	if !strings.HasPrefix(commits[1].Subject, "rename") {
		t.Errorf("commits[1] = %q, want rename", commits[1].Subject)
	}

	t.Run("limit", func(t *testing.T) {
		commits, err := repo.Log(ctx(), base, head, 1)
		if err != nil {
			t.Fatalf("Log: %v", err)
		}
		if len(commits) != 1 {
			t.Errorf("commits = %d, want 1", len(commits))
		}
	})
}

func TestDiffThreeDotVsTwoDot(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	// base = binary commit (has rename + binary on its side), head = feature.
	// Their merge base is c2. Three-dot must show only head-side changes
	// (feature.txt); two-dot compares the endpoints directly and surfaces the
	// base-only files.
	base := fxRev(t, reposRoot, "main^1")
	head := "feature/with-slash" // slash branch name passes through verbatim

	three, err := repo.Diff(ctx(), core.CompareSpec{Base: base, Head: head, ThreeDot: true})
	if err != nil {
		t.Fatalf("Diff three-dot: %v", err)
	}
	if !strings.Contains(three.Text, "feature.txt") {
		t.Errorf("three-dot diff missing feature.txt")
	}
	if strings.Contains(three.Text, "bin.dat") {
		t.Errorf("three-dot diff should NOT contain base-only bin.dat")
	}

	two, err := repo.Diff(ctx(), core.CompareSpec{Base: base, Head: head, ThreeDot: false})
	if err != nil {
		t.Fatalf("Diff two-dot: %v", err)
	}
	if !strings.Contains(two.Text, "bin.dat") {
		t.Errorf("two-dot diff should surface base-side bin.dat")
	}
}

func TestDiffStat(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	// c2 -> binary: a.txt renamed to a-renamed.txt, bin.dat added (binary).
	spec := core.CompareSpec{
		Base: fxRev(t, reposRoot, "main^1~2"),
		Head: fxRev(t, reposRoot, "main^1"),
	}
	files, err := repo.DiffStat(ctx(), spec)
	if err != nil {
		t.Fatalf("DiffStat: %v", err)
	}

	byPath := map[string]FileChange{}
	for _, f := range files {
		byPath[f.Path] = f
	}

	ren, ok := byPath["a-renamed.txt"]
	if !ok {
		t.Fatalf("missing rename entry; files = %+v", files)
	}
	if ren.Status != "R" || ren.OldPath != "a.txt" {
		t.Errorf("rename = %+v, want R from a.txt", ren)
	}

	bin, ok := byPath["bin.dat"]
	if !ok {
		t.Fatalf("missing bin.dat; files = %+v", files)
	}
	if bin.Status != "A" || !bin.Binary {
		t.Errorf("bin.dat = %+v, want A binary", bin)
	}
	if bin.Additions != 0 || bin.Deletions != 0 {
		t.Errorf("binary counts = %d/%d, want 0/0", bin.Additions, bin.Deletions)
	}
}

func TestTruncation(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	spec := core.CompareSpec{Base: fxRev(t, reposRoot, "main^1~3"), Head: "main", ThreeDot: true}

	full, err := repo.Diff(ctx(), spec)
	if err != nil {
		t.Fatalf("Diff (uncapped): %v", err)
	}
	if full.Truncated {
		t.Fatalf("baseline diff unexpectedly truncated")
	}
	if len(full.Text) <= 32 {
		t.Fatalf("fixture diff too small (%d bytes) to test truncation", len(full.Text))
	}

	repo.limitOverride = 32
	capped, err := repo.Diff(ctx(), spec)
	if err != nil {
		t.Fatalf("Diff (capped): %v", err)
	}
	if !capped.Truncated {
		t.Errorf("capped diff not marked truncated")
	}
	if len(capped.Text) > 32 {
		t.Errorf("capped diff = %d bytes, want <= 32", len(capped.Text))
	}
}

func TestMergeBase(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	got, err := repo.MergeBase(ctx(), fxRev(t, reposRoot, "main^1"), "feature/with-slash")
	if err != nil {
		t.Fatalf("MergeBase: %v", err)
	}
	want := fxRev(t, reposRoot, "main^1~2") // c2
	if got != want {
		t.Errorf("MergeBase = %q, want %q (c2)", got, want)
	}
}

func TestParents(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	t.Run("merge", func(t *testing.T) {
		parents, err := repo.Parents(ctx(), "main")
		if err != nil {
			t.Fatalf("Parents: %v", err)
		}
		if len(parents) != 2 {
			t.Errorf("parents = %v, want 2", parents)
		}
	})

	t.Run("root", func(t *testing.T) {
		parents, err := repo.Parents(ctx(), fxRev(t, reposRoot, "main^1~3"))
		if err != nil {
			t.Fatalf("Parents: %v", err)
		}
		if len(parents) != 0 {
			t.Errorf("root parents = %v, want none", parents)
		}
	})
}

func TestCommitPatch(t *testing.T) {
	reposRoot := newFixtureRepo(t)
	repo := openFixture(t, reposRoot)

	t.Run("root commit", func(t *testing.T) {
		root := fxRev(t, reposRoot, "main^1~3")
		patch, files, ci, err := repo.CommitPatch(ctx(), root)
		if err != nil {
			t.Fatalf("CommitPatch(root): %v", err)
		}
		if ci.SHA != root || len(ci.ParentSHAs) != 0 {
			t.Errorf("ci = %+v, want root with no parents", ci)
		}
		if !strings.Contains(patch.Text, "a.txt") {
			t.Errorf("root patch missing a.txt")
		}
		if len(files) != 1 || files[0].Path != "a.txt" || files[0].Status != "A" {
			t.Errorf("root files = %+v, want single A a.txt", files)
		}
	})

	t.Run("binary commit", func(t *testing.T) {
		bin := fxRev(t, reposRoot, "main^1")
		patch, files, _, err := repo.CommitPatch(ctx(), bin)
		if err != nil {
			t.Fatalf("CommitPatch(binary): %v", err)
		}
		if len(files) != 1 || files[0].Path != "bin.dat" || !files[0].Binary {
			t.Errorf("binary commit files = %+v, want single binary bin.dat", files)
		}
		if !strings.Contains(patch.Text, "bin.dat") {
			t.Errorf("binary patch missing bin.dat header")
		}
	})

	t.Run("merge commit diffs against first parent", func(t *testing.T) {
		patch, files, ci, err := repo.CommitPatch(ctx(), "main")
		if err != nil {
			t.Fatalf("CommitPatch(merge): %v", err)
		}
		if len(ci.ParentSHAs) != 2 {
			t.Fatalf("expected merge commit, parents = %v", ci.ParentSHAs)
		}
		// vs first parent (binary commit), the merge brings in feature.txt.
		if len(files) != 1 || files[0].Path != "feature.txt" {
			t.Errorf("merge files = %+v, want feature.txt", files)
		}
		if !strings.Contains(patch.Text, "feature.txt") {
			t.Errorf("merge patch missing feature.txt (diff-tree -p on a merge is empty; must diff vs parent)")
		}
	})
}